search

ui5-community / generator-ui5-project

Generator for UI5-based web-apps which use the official UI5 tooling and support multiple deployment targets such as the SAP Business Technology Platform
Apache License 2.0
44 stars 27 forks source link

fix(tests): Error: No parser could be inferred for file #41

Closed marianfoo closed 2 years ago

marianfoo commented 2 years ago

PR was opened because of the error in the actions: https://github.com/ui5-community/generator-ui5-project/runs/5611992482?check_suite_focus=true

Seems like @nicogeburek tried to fix it with this commit? https://github.com/ui5-community/generator-ui5-project/commit/cc61307d909f8dc07b8ab5de396192a011eb621e

My solution was to add --ignore-unknown because of this entry: https://github.com/prettier/prettier/blob/24d39a906834cf449304dc684b280a5ca9a0a6d7/website/blog/2020-08-24-2.1.0.md#added---ignore-unknownalias--u-flag-8829-by-fisker

Solution was wrong, reverted the old solution. New solution:

Based on a old prettier issue (https://github.com/prettier/prettier/issues/8056) i found this workaround: https://github.com/withastro/prettier-plugin-astro/issues/97#issuecomment-1013645333

pass --plugin-search-dir=. to the prettier cli

This solution makes more sense because in the error log is: Error: No parser could be inferred for file: uimodule/webapp/view/MainView.view.xml

So probably prettier does not find the prettier plugin @prettier/plugin-xml to parse xml. With this solution prettier uses the plugin.

marianfoo commented 2 years ago

CC @petermuessig

petermuessig commented 2 years ago

Merged, thanks @marianfoo