ui5-community / generator-ui5-project

Generator for UI5-based web-apps which use the official UI5 tooling and support multiple deployment targets such as the SAP Business Technology Platform
Apache License 2.0
33 stars 25 forks source link

App.controller.js has wrong namespace #55

Closed MichaelFlucher closed 1 year ago

MichaelFlucher commented 1 year ago

Easy-Ui5 version:

3.5.0

Run yo easy-ui5 --plugins to print all relevant version strings

Node.js: v16.13.0 yeoman-environment: 3.10.0 generator-easy-ui5: 3.5.0 Available generators:

OS/version:

Windows 10 Enterprise 21H2 19044.1826

Browser/version (+device/version):

Steps to reproduce the problem:

yo easy-ui5 project app

? How do you want to name this project? generatorBug
? Which namespace do you want to use? test
? Do you want to enable the SAP Fiori elements flexible programming model? No
? On which platform would you like to host the application? SAP Launchpad service
? Which view type do you want to use? XML
? Where should your UI5 libs be served from? Content delivery network (SAPUI5)
? Would you like to create a new directory for the project? No
? Would you like to add JavaScript code assist libraries to the project? No  
? Would you like to initialize a local git repository for the project? No
? What name should be displayed on the Fiori Launchpad tile? App1

What is the expected result?

return BaseController.extend("test.generatorBug.controller.App", {

What happens instead?

return BaseController.extend("test.generatorBug.controller.controller.App", {

Any other information? (attach screenshot if possible)

wridgeu commented 1 year ago

Hey there,

nice find. :)

Looks like it'll have to be changed in https://github.com/SAP/open-ux-tools/blob/cada427943dccee6382e1ce0e7ec8ba210996493/packages/fiori-freestyle-writer/templates/basic/add/webapp/controller/App.controller.js

@tobiasqueck Is there a certain way to go about handling these cross repository things like a "requirement" let's say, to have this issue opened over at the open-ux-tools as well or will a straight PR with a link to this issue be enough?