Being composable from other generators

ui5-community / generator-ui5-project

Generator for UI5-based web-apps which use the official UI5 tooling and support multiple deployment targets such as the SAP Business Technology Platform

Apache License 2.0

44 stars 27 forks source link

Being composable from other generators #6

Closed dh4rry closed 3 years ago

dh4rry commented 3 years ago

Fix Issue #5 Being composable from other generators:

Subgenerators newwebapp, newmodel and newview are now using options in case there are no attributes in the config (which is scoped by the generator and could not be set via an external generater).

IObert commented 3 years ago

Thanks for your PR. I'll test this in more detail next week.

IObert commented 3 years ago

Thanks for your contribution!

IObert commented 3 years ago

Sorry, I had to roll back your changes as they broke the generator. It is strange that the automation tests didn't find this.

I'll have a look at the exact cause tomorrow and try to make sure that the tests catch something like this. Can you please address the original issue (SAP/generator-easy-ui5#75) and open another PR?