Closed nicoschoenteich closed 1 year ago
All the test are passing locally, just a matter of getting it to work here...
Phew, that wasn't easy, but I think we now have a foundation to work with.
I had to update quite a few dependencies to finally support node v18 (see issue here), which required to turn the project into an ES module, as a few of the updated dependencies must be used with import
- see previous investigations. I also considered https://github.com/SAP/generator-easy-ui5/pull/82 and fixed https://github.com/ui5-community/generator-ui5-project/issues/23 ➡️ with yeoman-generator^5
the generator-ui-project
now doesn't run its own npm install
, but let's yeoman handle the autoinstall (see https://github.com/ui5-community/generator-ui5-project/pull/62/commits/f205b23e226d2122a3f6b61540d56f8234a96b77)
Very much looking forward to everyone's feedback!
With the new UI5 Tooling v3 requiring node >= 18 I think this PR has become more important. Looking forward to your feedback @vobu @petermuessig 😊
I was linked to this PR from the related question on the SAP Community, answered by @nicoschoenteich. The described issue persists with Node v19 as well...
When following the "Create an App for SAP Build Work Zone, standard edition" Tutorial, running yo easy-ui5 project
is recommended. This command currently fails with a Error: ENOENT: no such file or directory, scandir '/Users/currentuser/tutorial.products/uimodule/ui5-local.yaml'
error using Node.js v19.9.0.
@petermuessig @vobu @nicoschoenteich any update on this PR, please? would appreciate if it was merged and closed to unblock using node 18+. Thanks!
additionally, please wait until #66 is in, as this has the move to ui5/cli^3
let's see if the tests pass...