search

ui5-community / generator-ui5-ts-app

Generator for UI5 applications using TypeScript which use the official UI5 tooling. This generator was built as a plug-in for the community project Easy UI5 by SAP.
Apache License 2.0
19 stars 15 forks source link

Feature base controller #10

Closed AlexanderK22 closed 2 years ago

AlexanderK22 commented 2 years ago

I've added the BaseController.ts. The App.controller.ts and the Main.controller.ts were also changed to extend from it.

AlexanderK22 commented 2 years ago

I've updated the JSDoc in the BaseController.ts

AlexanderK22 commented 2 years ago

@petermuessig Using a relative URL is probably the better option. I've updated it in the App and Main controller. Thanks for the suggestion 👍.

AlexanderK22 commented 2 years ago

Hi @petermuessig, I'd appreciate your assitance in this matter, to resolve the issue as quickly as possible.

Thanks in advance.

petermuessig commented 2 years ago

@AlexanderK22 - ok, I'll try to reserve some time today evening or tomorrow morning to fully sort this out. Big thanks to your contribution so far... 👍

AlexanderK22 commented 2 years ago

@petermuessig thanks again. Glad I could help out a bit.

petermuessig commented 2 years ago

@AlexanderK22 @vobu - codebase is cleaned-up now and should be good to go. The eslint checks are now reporting no issue anymore. 😄

petermuessig commented 2 years ago

@AlexanderK22 - thanks for your contribution. It's merged now, feel free to test it and provide feedback... 😄

AlexanderK22 commented 2 years ago

@petermuessig Great! I will test it and let you know if there are any issues.