search

ui5-community / generator-ui5-ts-app

Generator for UI5 applications using TypeScript which use the official UI5 tooling. This generator was built as a plug-in for the community project Easy UI5 by SAP.
Apache License 2.0
19 stars 15 forks source link

feat: add formatter and models #11

Closed marianfoo closed 1 year ago

marianfoo commented 2 years ago

Description

Adding models.ts and formatter.ts otherwise the js files from main template is used

Changes

petermuessig commented 2 years ago

Cc @akudev - FYI, this is indeed a good extension to the template.

@marianfoo : maybe we should also use the formatter and the model somewhere?

marianfoo commented 2 years ago

@petermuessig added the formatter to the Main.controller the model is already used in the Component

marianfoo commented 2 years ago

@petermuessig @akudev all good here?

akudev commented 2 years ago

I'm not really taking care of this app generator. Maybe @petermuessig can have a look.

marianfoo commented 2 years ago

@petermuessig can I merge?

petermuessig commented 2 years ago

@marianfoo I discussed this with @akudev and we keep that change open till after UI5con since it would alter the generated output: https://github.com/SAP-samples/ui5-typescript-tutorial

marianfoo commented 1 year ago

@marianfoo I discussed this with @akudev and we keep that change open till after UI5con since it would alter the generated output: https://github.com/SAP-samples/ui5-typescript-tutorial

all good here? any changes?

akudev commented 1 year ago

@marianfoo I'd suggest to merge this as soon as the fork/copy of the template in the tutorial repo is fully functional and its usage within the tutorial flow is documented. Then this template is decoupled from the tutorial and can be changed in any way.

akudev commented 1 year ago

From my perspective this PR can be merged now. But I'm not considering myself maintainer here, so @petermuessig ?