search

ui5-community / generator-ui5-ts-app

Generator for UI5 applications using TypeScript which use the official UI5 tooling. This generator was built as a plug-in for the community project Easy UI5 by SAP.
Apache License 2.0
19 stars 15 forks source link

fix: proper appId setting #2

Closed pfefferf closed 3 years ago

pfefferf commented 3 years ago

App should be generated with a "proper" app id considering namespace + application.

Example:

Instead of having an app id "ui5.typescript" I want to have an app id "ui5.typescript.helloworld", right?

Adjustments are made in a way that the generator adds additional configuration properties appId and appURI which are then used at all relevant places. In addition tsconfig was updated to remove the hard coded string "ui5/typescript/helloworld" for path resolutions. package-lock.json updated too (seemed to be a still an unadjusted copy of the non-ts generator).

petermuessig commented 3 years ago

@pfefferf - thanks for your PR - that happens if things are just hacked together quickly. Yes, you are right, the appId should be used instead of the namespace. Very good catch! 👍