fix(ui5-tooling-modules): fixed some dependencies falsely assumed to be located in project root

ui5-community / ui5-ecosystem-showcase

A repository showcasing the UI5 tooling extensibility to combine OSS tools for UI5 application development.

https://ui5-community.github.io/ui5-ecosystem-showcase/

Other

194 stars 94 forks source link

fix(ui5-tooling-modules): fixed some dependencies falsely assumed to be located in project root #1032

Closed igzThomasFrischholz closed 4 months ago

igzThomasFrischholz commented 4 months ago

When using ui5-tooling-modules in combination with signalr packages the dependency for "punycode" was assumed to be located in the project root and not inside node_modules subfolders. By changing the search order of file extensions in util.js this bug will not occur.

petermuessig commented 4 months ago

Hi @igzThomasFrischholz

I also setup a small test for this but I can't see punycode being a dependency of signalr. Can you share a bit more details about your project setup? The search order is like that so that when requiring modules without their concrete path in the package they first try to resolve the NPM package with the main/module field. This would change the lookup a bit and I need to understand that first...

petermuessig commented 4 months ago

BTW: punycode is also included as package in Node.js and resolves to a native module. This could be the difference here...