ui5-community / ui5-ecosystem-showcase

A repository showcasing the UI5 tooling extensibility to combine OSS tools for UI5 application development.
https://ui5-community.github.io/ui5-ecosystem-showcase/
Other
189 stars 92 forks source link

different line endings in generated <controller>-dbg.controller.js files #1035

Closed Joker2015 closed 1 month ago

Joker2015 commented 1 month ago

Hello everyone,

I'm generating a sapui5 project from Typescript sources. The command line

ui5 build --clean-dest --include-task=generateCachebusterInfo

creates a new "dist" directory with several target files per source. One of these files is the "debug controller" -dbg.controller.js (i.e. App-dbg.controller.js).

When uploading the created files to the ABAP repository using the ADT service, the service complains about different line endings in one file. A closer inspection found out that the generated file -dbg.controller.js uses CRLF as line ending on every line except in the last two lines, where only LF is used.

I'm using

I hope that that problem is really caused by this plugin, if this is not the case please point me to the correct package. best regards - Joachim

petermuessig commented 1 month ago

Found it - good catch - I'll fix it

petermuessig commented 1 month ago

On Mac it would not have happened 😉

Joker2015 commented 1 month ago

many thanks for your fast response