ui5-community / ui5-ecosystem-showcase

A repository showcasing the UI5 tooling extensibility to combine OSS tools for UI5 application development.
https://ui5-community.github.io/ui5-ecosystem-showcase/
Other
191 stars 92 forks source link

[ui5-tooling-transpile-task] transpiled Javascript lacks renderer declaration #964

Closed BenReim closed 6 months ago

BenReim commented 6 months ago

When extending a UI5 Control where the render shall be inherited, a renderer member can be declared.

However the renderer declaration is missing in the build result (transpiled JS file), which causes the UI5 runtime to incorrectly require the control renderer from the reuse library namespace.

Reproducible sample: https://github.com/ui5-community/ui5-ecosystem-showcase/pull/963

petermuessig commented 6 months ago

Hi Benjamin,

this issue goes down to the https://github.com/ui5-community/babel-plugin-transform-modules-ui5 project. It seems that it can't handle the renderer yet. I need to check if we can simply add this with small efforts.

BR, Peter

BenReim commented 6 months ago

@petermuessig I realized that I made a mistake when declaring the renderer member 🙃 so it's actually not a bug in the plugin

- static renderer: { apiVersion: 2; };
+ static renderer= { apiVersion: 2; };