search

ui5-community / ui5-ecosystem-showcase

A repository showcasing the UI5 tooling extensibility to combine OSS tools for UI5 application development.
https://ui5-community.github.io/ui5-ecosystem-showcase/
Other
194 stars 93 forks source link

Adjusted ui5-tooling-stringreplace to work with .ts files #980

Closed KevinC0210 closed 8 months ago

KevinC0210 commented 8 months ago

I adjusted fetching the MimeInfo fetching as currently the type for all .ts files will result in "video/mp2t" and therefore will be ignored by the stringreplace-task. With this change the stringreplace-task can also detect and replace strings in any TypeScript files.

Please also refer to this issue: https://github.com/ui5-community/ui5-ecosystem-showcase/issues/979

petermuessig commented 8 months ago

You are right, TypeScript isn't detected properly - but maybe JavaScript is not the proper type and we should use "text/plain" or and custom mime type like "application/x-typescript" - but I'll correct it in a separate change. THX for the FIX 🚀