ui5-community / wdi5

official UI5 end-to-end test framework for UI5 web-apps. wdi5 = Webdriver.IO + UI5 Test API
https://ui5-community.github.io/wdi5/
Apache License 2.0
102 stars 43 forks source link

Prerequisites add libs #300

Closed tobiashofmann closed 2 years ago

tobiashofmann commented 2 years ago

Describe the bug

The installation states in the prerequisites section that if no CDN is used, two libs should be added via ui5 tooling: sap.base sap.ui.test

Trying to install both gives an error:

Failed to find OpenUI5 framework library sap.base: 404 Not Found - GET https://registry.npmjs.org/@openui5%2fsap.base - Not found

To Reproduce

Doc: https://ui5-community.github.io/wdi5/#/installation?id=prerequisites

Run: ui5 add sap.base sap.ui.test

Expected behavior

The installation as outlined in the Installation readme should work.

Additional context

Looking at the npmjs repository, both libraries are not listed for OpenUI5 or SAPUI5.

https://www.npmjs.com/search?q=%40openui5

https://www.npmjs.com/search?q=%40sapui5

Siolto commented 2 years ago

Hi @tobiashofmann,

thanks for pointing that out. I just had a look and both namespaces (sap.base and sap.ui.test) are, according to the API, available with the same library: sap.ui.core. Since sap.ui.core is more or less mandatory for every UI5 application I think we can remove this hint from the prerequisites completely.

I will double check this and then create a PR for that.

Best regards, Simon