uias / Pageboy

📖 A simple, highly informative page view controller
MIT License
1.99k stars 154 forks source link

Second swipe when the first is not finished #157

Closed jbdujardin closed 6 years ago

jbdujardin commented 6 years ago

Hi!

Sorry for my bad english... I have found a bug when I do a second swipe and the first is not finished :

The screen record :

ezgif com-optimize

Thanks for your help

msaps commented 6 years ago

@jbdujardin any hints on how to reproduce this? I'm really struggling to find it

jbdujardin commented 6 years ago

@msaps With the exemple, you start a incomplete light swipe to the second page and before the swipe returns to its original position you do a full swipe to the second page. It's not easy to reproduce but in iPad application it's really binding.

msaps commented 6 years ago

@jbdujardin ah found it!

msaps commented 6 years ago

@jbdujardin can you check out 2.5.0 and see if it fixes the issue? This has been reported before but I've never been able to nail it down!

A 12.9" iPad was the key! 😉

jbdujardin commented 6 years ago

@msaps Perfect! It works perfectly! Thank you for your good work and your nice library :)

msaps commented 6 years ago

@jbdujardin great! Thank you!! 😄

aaasifrz9 commented 6 years ago

Hi @msaps ,

I tried pod with 2.5 version, not working. Hove you updated pod?

aaasifrz9 commented 6 years ago

Hi @msaps ,

I tried 2.5.0 in my project. I have added 6 childs. Steps:- 1- On app starts app loads first child. 2- Then I swipe to move 2nd child and it moves. 3- Then I tried to swipe fast (swipe swipe swipe ...) then it crashes with black screen. I got jump issue again. See the log last 6 lines.

I have attached crash log with screenshots. Please review and let us know. How to fix it. Error log.zip

Thanks Asif

dfmarulanda commented 5 years ago

ezgif-1-5d9192d2b678