search

uias / Pageboy

📖 A simple, highly informative page view controller
MIT License
1.99k stars 154 forks source link

Updated for swift 5. #215

Closed kajensen closed 5 years ago

kajensen commented 5 years ago

Update podspec to swift 5.

kajensen commented 5 years ago

I realize there is already a Swift 5 release but I noticed two Xcode 10.2 warnings and the podspec swift_version needed to be bumped.

uias-bot commented 5 years ago
1 Warning
:warning: Looks like you changed some source files, should there have been some tests added?

Generated by :no_entry_sign: Danger

msaps commented 5 years ago

@kajensen we actually need to lower the podspec Swift version to 4.0 - we support both Swift 4 & 5 and I believe the only way to do that is to have the project version set as the lower bound.

I believe CocoaPods 1.7.0 will support podspec specifying multiple versions of Swift support, so as soon as that is publicly available we will support it 👍

kajensen commented 5 years ago

Sounds good re cocoa pods 1.7 👍

On Apr 23, 2019, at 2:07 PM, Merrick Sapsford notifications@github.com wrote:

@kajensen https://github.com/kajensen we actually need to lower the podspec Swift version to 4.0 - we support both Swift 4 & 5 and I believe the only way to do that is to have the project version set as the lower bound.

I believe CocoaPods 1.7.0 will support podspec specifying multiple versions of Swift support, so as soon as that is publicly available we will support it 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uias/Pageboy/pull/215#issuecomment-485913005, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVADSKR3LMQTJTY2V6V5RTPR5F4LANCNFSM4HHYY4SQ.