uic-utah / uic-inventory

a public web application to manage the creation, permitting, and payment for underground injection control sites in Utah
1 stars 0 forks source link

Inventory Report layout #273

Closed nathankota closed 10 months ago

nathankota commented 1 year ago

Using the mockup document as a guide (page 2 of the doc, onward). (Side note: The PLSS app's monument record sheet was the inspiration for the report layout and design.)

First Page(s)

New page

New page

New page

New page

New page

Last page(s)

steveoh commented 11 months ago

are we running a footer like plss's

image
steveoh commented 11 months ago

Here's the start. Any changes required for these?

image
nathankota commented 11 months ago

Looking great so far! @rsparker-utah, please review the draft above and comment on any needed changes.

steveoh commented 11 months ago

Here's a full sample. Please comment on it's format

uic-report-sample.pdf

nathankota commented 11 months ago

DWQ team is currently reviewing and we expect feedback shortly.

steveoh commented 11 months ago

This is the most recent iteration. uic-form-sample.pdf

nathankota commented 11 months ago

@rsparker-utah 👀

This is the most recent iteration. uic-form-sample.pdf

rsparker-utah commented 11 months ago

This is looking great! We had a few comments from our review:

  1. Could the email field be added for each of the contacts on page 1 under the "Site Contacts" section?
  2. Could the "Contat" label be updated to "Contact" on page 3 under the "Water System Information" section?
  3. The review group liked the idea of including a disclaimer footer. Provided it's ok to do so, would we be able to reuse the footer from plss for this application as well: The state of Utah makes no guarantees, representations, or warranties of any kind, expressed or implied, as to the content, accuracy, timeliness, or completeness of any of the data. Unless otherwise noted all images are oriented North and are not to scale. The data is provided on an “as is, where is” basis. The State assumes no obligation or liability for its use by any persons.
steveoh commented 11 months ago

Yes the email can be added. It's in there now and the spelling mistake is also corrected.

Provided it's ok to add the footer... who decides if it's ok?

rsparker-utah commented 11 months ago

@nathankota Do you know if it's ok for us to reuse the plss footer verbiage? If we're unsure, I can write something up.

nathankota commented 11 months ago

@nathankota Do you know if it's ok for us to reuse the plss footer verbiage? If we're unsure, I can write something up.

@rsparker-utah The disclaimer can be whatever you want/need it to be. I don't know of any use restrictions of the PLSS verbiage, but your team or legal representative (Cate?) would be better at answering whether it's appropriate for this particular app and data. You tell us what you want in there and we'll do it :)

rsparker-utah commented 11 months ago

Ok, gotcha, that sounds good. Our review group seemed to like the plss verbiage, but I better run it by Cate first. Let's hold of on that piece for time being. I'll provide an update after I chat with Cate.

steveoh commented 11 months ago

I've got this in there now...

image

I removed the page numbers because the user uploaded pdfs won't also have them and then it will be confusing

rsparker-utah commented 11 months ago

I ran the disclaimer by our Data Management Specialist and have an update regarding the disclaimer. Could we add a sentence at the end of the existing disclaimer so it reads:

The State of Utah makes no guarantees, representations, or warranties of any kind, expressed or implied, as to the content, accuracy, timeliness, or completeness of any of the data. Unless otherwise noted all images are oriented North and are not to scale. The data is provided on an “as is, where is” basis. The State assumes no obligation or liability for its use by any persons. Identified inaccuracies can be reported to uic-inventory@utah.gov.

steveoh commented 11 months ago

I've pushed the work I have done so far to dev. Please test it and see what you think. The appendix files are not currently being fetched and attached. Otherwise I think we have everything in the report that was in the mockup. Make sure your browser allows a popup.

nathankota commented 11 months ago

As far as report layout, it looks correct/accurate/great to me. @rsparker-utah we now defer to you for final validation.

steveoh commented 11 months ago

the well detail pdf's are now appended to the report. I deleted all of the cloud storage to remove any non pdf files. When you test you will need to update the well details for the inventory you are testing to add new files.

rsparker-utah commented 11 months ago

I created a new test site (i.e., https://uic-inventory.dev.utah.gov/review/site/118/inventory/212), submitted an inventory, and downloaded the Inventory Report. I think the report layout looks great! I did have a couple review comments:

1.) On page 3 of the report, it looks like the "Construction" field isn't populating in the table under "Well Information". image 2.) Also it looks like the GWZ indicator functionality may not be working in the app which is carrying over to the Inventory Report. For example, on page 3 of the report, the site should be in a GWZ, but the GWZ indicator in the report appears to be red: image image

steveoh commented 10 months ago

construction is fixed

image

We should track any GWZ issues in a new issue

steveoh commented 10 months ago

Drinking water changed their service url. I've got that fixed now also. These are all the well ids that failed

image
nathankota commented 10 months ago

@rsparker-utah please give this another try

rsparker-utah commented 10 months ago

I did a new round of testing on a new site (i.e., https://uic-inventory.dev.utah.gov/review/site/119/inventory/213), submitted an inventory, and downloaded the Inventory Report. I didn't come across any issues and I think the report layout looks really good! Thanks Steve!