search

uic-utah / uic-inventory

a public web application to manage the creation, permitting, and payment for underground injection control sites in Utah
1 stars 0 forks source link

Account Permission Re-direction Notification Adjustment #322

Closed rsparker-utah closed 5 months ago

rsparker-utah commented 5 months ago

I came across this discrepancy during testing of #143. I used my admin account to navigate to the site details, site contacts, and site location pages of a site (i.e., 124) not created by either my admin account or my public account. I then copied the following links for each:

and pasted them into a separate browser logged into my public account and hit enter. Instead of being directed to the "How did you get here?" page, my public account was routed to the incomplete site notification page: image

Would it be possible to make it so in cases like this for the public account where it is showing the incomplete inventory notification when navigating to links that the account shouldn't have access to (i.e., the site details, contacts, and location for sites the account didn't create), it instead showed the "How did you get here?" page? for example: image

steveoh commented 5 months ago

I noticed that links to deleted inventories don't provide a good experience.

steveoh commented 5 months ago

The site is currently building and I believe I have addressed the original issue. Please validate.

rsparker-utah commented 5 months ago

This looks great and is working as expected. For reference, to test this, I used my admin account to navigate to the Site, details, contacts, and location pages for several sites not created by my public account (i.e., sites 124, 144, and 145). I then copied the links for each of these pages, logged into my public account in a separate browser, and tried to navigate to each of the copied links. For each of the links I received the updated notification: image