uic-utah / uic-inventory

a public web application to manage the creation, permitting, and payment for underground injection control sites in Utah
1 stars 0 forks source link

Allow 3rd party entities to upload owner/operator or legal representative signature #348

Closed steveoh closed 1 month ago

steveoh commented 2 months ago

Update “Sign and Submit” page with the following:

image

Update the Inventory report with the following:

image

https://docs.google.com/document/d/1X3dfm9eLRMjZTlb2dsSxKOjXdHWucq4TJTcyigoXhQk/edit

steveoh commented 2 months ago

@rsparker-utah are you happy with this UI so far?

image
rsparker-utah commented 2 months ago

@steveoh Yes, this looks great! I have one minor text edit request. Could we adjust the text slightly in the first sentence from: This UIC Inventory Information Form must be signed by the owner, operator, or legal representative's of the injection well(s) for which the inventory information is being submitted. To: This UIC Inventory Information Form must be signed by the owner, operator, or legal representative of the injection well(s) for which the inventory information is being submitted.

steveoh commented 2 months ago

Yep sorry. I made that change since it was plural later on. Easy fix!

steveoh commented 2 months ago

@rsparker-utah I spun up the dev project and pushed these there. https://uic-inventory.dev.utah.gov

Would you mind giving it a spin and see what you think. The file uploads take a minute to get scanned and migrated to the safe cloud storage so if the pdfs aren't available instantly give the scanner a minute to fire up and scan/move them before trying again.

rsparker-utah commented 2 months ago

@steveoh We were able to run through this new functionality and it was working well. We think this will work nicely, thank you!

I was also able to confirm in the test environment that old inventories (i.e., inventories that were processed through the system before the signature update went into effect) will fail to download after the update is made. There are currently inventories at the following varying statuses (in the prod environment):

Draft - 5 Submitted - 1 Under Review - 2 Approved - 3 Authorized - 1 Completed - 6

I don't foresee this being an issue for inventories that have already been processed (i.e., inventories with a status = "Completed"), since we store copies of the generated completed Inventory Packets in our document management system. The inventories at other statuses may need some further consideration (e.g., should we wait until all these are processed and "Completed" before implementing the update or is there another work around we could consider?).

steveoh commented 2 months ago

@rsparker-utah I can take a stab at treating the previous submissions as a part of this fix and make them both succeed. That will make old redownloads continue to work as well as the ones in process. Or we can wait. I think it's your call.

rsparker-utah commented 2 months ago

@steveoh Ok, that would be great if you wouldn't mind looking at the previous submissions as part of this fix.

steveoh commented 2 months ago

@rsparker-utah I believe this is performing how you expect. Please verify and let me know how to proceed.

rsparker-utah commented 1 month ago

@steveoh I was able to run through some testing in the dev environment. Quick summary of my testing workflow:

  1. I created a new site/inventory (i.e., site 164, inventory 321) and verified again that the signature update was working as expected,
  2. I then tested downloading inventory packets from both sites/inventories created after the 3rd party signature functionality was updated (i.e., site 164, inventory 321 and site 161, inventory 317) and sites that were created before the 3rd party signature functionality was updated (i.e., site 156, inventory 308 and site 138, inventory 275).

The inventories downloaded successfully for all of the above test sites/inventories. I noticed one potential minor formatting bug as I was writing up my testing workflow. It looks like the "Location Details" heading is being duplicated across the first and second pages of the Inventory Information Report, for example: image

Other than that, things are looking great. Thanks again for implementing the extra inventory packet download fix!

steveoh commented 1 month ago

When would you like this pushed to production?

rsparker-utah commented 1 month ago

@steveoh We're good to have the fix pushed to production at your earliest convenience. Thanks!

steveoh commented 1 month ago

@rsparker-utah this was just deployed to production.