uicrooks / shopify-theme-lab

Shopify theme development environment using Liquid, Vue and Tailwind CSS. Built on top of Shopify CLI 🧪
https://uicrooks.github.io/shopify-theme-lab-docs/
MIT License
727 stars 128 forks source link

Adding support for ESLint in VSCode #143

Closed haotan19 closed 2 years ago

haotan19 commented 2 years ago

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

In VSCode with ESLint extension:

Before:

Issues #142 , no error display in VSCode.

before

After:

after

Tested on Windows 10 & macOS 12


The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

Other information:

haotan19 commented 2 years ago

Sometimes the ESlint extension says doesn't support the "configFile" on my Windows 10 machine, but other times it doesn't have any issues at all.

sergejcodes commented 2 years ago

This seems to solve the issue. I'll test it further and if no issues arise it will be implemented in the next update.

haotan19 commented 2 years ago

The ESLint would tell me to use "overrideConfigFile": ".config/.eslintrc.js", instead of "configFile". overrideConfigFile works on my Windows 10 PC, but I am not sure it can work on my macOS (it's the same as not having a config file when using overrideConfigFile).