What kind of change does this PR introduce? (check at least one)
[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ x ] Other, please describe:
add favicon to theme settings,
The favicon tutorial in the official shopify documentation led me to theme settings,
But i can't find favicon
After spending some time,I found that the reason is no favicon in settings_schema
So I added, although it is a little problem,it will help people who just use it😃
Does this PR introduce a breaking change? (check one)
[ ] Yes
[ x ] No
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
[ x ] It's submitted to the dev branch, not the main branch
If adding a new feature, the PR's description includes:
[ x ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
What kind of change does this PR introduce? (check at least one)
add favicon to theme settings, The favicon tutorial in the official shopify documentation led me to theme settings, But i can't find favicon After spending some time,I found that the reason is no favicon in settings_schema So I added, although it is a little problem,it will help people who just use it😃
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch, not themain
branchIf adding a new feature, the PR's description includes:
Other information: