Open vivgui opened 2 years ago
Hey guys, at barrel created a Vite/Shopify plugin that I think you will love (:
https://user-images.githubusercontent.com/5134470/179859946-806ae51a-0ac7-4917-b319-c52a1bc64140.mp4
@montalvomiguelo what's the github repo? would like to take a look
I wanted to follow up on this, is there anything you want me to change/talk about before this can be approved?
when is this going to be approved?
+1 would love to see this implemented!
+1 this is just what I'm missing from the current implementation
+1
+1
The project currently uses webpack for assets bundling but there's an interest in switching to Vite. This PR attempts to do that migration. I first tested this on the foundation theme (you can see my repo fork here) and things worked correctly.
One major thing that the migration to Vite changed is that Vite doesn't use
.browserslistrc
for setting browser compatibility, it usesesbuild
instead so the.config/.browserslistrc
file is not needed.Besides that, I tried my best to replace all the webpack-specific functionality using Vite plugins and configurations.
I know this is a significant change and I'm open to discussing how to best approach it. I just wanted to demonstrate that migrating to Vite is possible and worthwhile.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch, not themain
branchIf adding a new feature, the PR's description includes:
Other information: