uicrooks / shopify-theme-lab

Shopify theme development environment using Liquid, Vue and Tailwind CSS. Built on top of Shopify CLI ๐Ÿงช
https://uicrooks.github.io/shopify-theme-lab-docs/
MIT License
737 stars 130 forks source link

Conflict with @shopify alias #77

Closed ccanete closed 3 years ago

ccanete commented 3 years ago

Hi @sergejcodes

The new @shopify alias in webpack comes into conflict if you add one of the shopify theme-scripts to your app.

I'm using the @shopify/theme-images library for responsive images and webpack fails to build the project when I import the package.

Link to the config issue: https://github.com/uicrooks/shopify-theme-lab/blob/7dea52b2018a942f11ba7d261c5eb42c6517fb6c/.config/webpack/webpack.common.js#L18

I don't know if there is a way to avoid webpack alias when importing the lib.

One solution would be to change the alias.

I removed the alias from my project but it could happen to someone else. I just wanted to share this.

Thanks for your work ๐Ÿ’ช๐Ÿ’ช๐Ÿ’ช

sergejcodes commented 3 years ago

Hi ๐Ÿ‘‹,

thanks for bringing it up. I'm changing the alias in the latest release