uikit / uikit-site

🌎 Website and Documentation
https://getuikit.com
365 stars 331 forks source link

Tiny typo: Missing a dot '.' in front of a classname + Duplicated id in for the anchor heading #164

Closed hrvojegolcic closed 5 years ago

hrvojegolcic commented 5 years ago

Assumingly there is a dot missing in front of a classnames: "uk-margin-auto" for each of the responsive viewports on the page https://getuikit.com/docs/margin

image

Additionally, the link with a "responsive" anchor in the URL would not work either since there are two headings with the id "#responsive" on that page. e.g. https://getuikit.com/docs/margin#responsive will open only the first heading "Responsive", not the second one which I wanted to post for this issue.

saschadube commented 5 years ago

Thanks! I fixed it in the develop branch. https://github.com/uikit/uikit-site/commit/946774c73da101e9d201f04b387414db1cc4851e

hrvojegolcic commented 5 years ago

Hey cool! Just want to point out that there was another issue if it was foreseen in the upper post:

there are two headings with the id "#responsive" on that page. e.g. https://getuikit.com/docs/margin#responsive will open only the first heading "Responsive", not the second one which I wanted to post for this issue.

Also it's not valid to have two elements with same id in HTML