search

uikit / uikit-site

🌎 Website and Documentation
https://getuikit.com
365 stars 331 forks source link

HOVER buttons don't have a hover action #8

Closed lukehutch closed 7 years ago

lukehutch commented 7 years ago

Some of the buttons in the docs say "HOVER", but they don't have a hover action, and they are actually clickable buttons. For example, the two "HOVER" buttons in https://getuikit.com/docs/drop#usage .

(I think I saw one or two other cases of this -- you might want to grep the docs for all buttons with "Hover" in their text.)

janschoenherr commented 7 years ago

I believe this has been resolved, thanks.

lukehutch commented 7 years ago

@janschoenherr This is still not resolved for me. Hovering over the "HOVER" buttons does not cause the menu to pop up.

janschoenherr commented 7 years ago

Are you still using Chrome? Is it a touch device?

lukehutch commented 7 years ago

Yes, this is Chrome on Linux, desktop (not touch).

janschoenherr commented 7 years ago

Did you clear your browser cache?

lukehutch commented 7 years ago

I just tried that, and it didn't change the behavior.

I looked at the resources being loaded, and I see "theme.css?141". I assume the "?141" part is supposed to get bumped every time there's a code checkin, and that browsers are not supposed to cache if URL query parameters change? (Why not use an SHA1 hash instead of a number?)

janschoenherr commented 7 years ago

Can you try it in another browser?

lukehutch commented 7 years ago

Sure, it's also not working in Firefox, or in Vivaldi (which is based on Blink, so the behavior in Vivaldi is likely to match the Chrome behavior). (Both are on the same Linux desktop machine.)

janschoenherr commented 7 years ago

Could you please give it another try, is it working for you now?

lukehutch commented 7 years ago

@janschoenherr Solved for me in Chrome on Linux.Thanks!