search

uilibrary / matx-react

Matx -Free and open-source React Material UI Admin Dashboard Template
https://ui-lib.com/downloads/matx-react-dashboard
MIT License
925 stars 389 forks source link

Does not compile on node 14.2 / macOS #6

Closed haf closed 3 years ago

haf commented 4 years ago 
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/Cellar/node/14.2.0/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --library=static_library --module=/Users/h/dev/haf/matx-react/node_modules/grpc/src/node/extension_binary/node-v83-darwin-x64-unknown/grpc_node.node --module_name=grpc_node --module_path=/Users/h/dev/haf/matx-react/node_modules/grpc/src/node/extension_binary/node-v83-darwin-x64-unknown --napi_version=6 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v83' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/h/dev/haf/matx-react/node_modules/grpc/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1051:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
node-pre-gyp ERR! System Darwin 19.4.0
node-pre-gyp ERR! command "/usr/local/Cellar/node/14.2.0/bin/node" "/Users/h/dev/haf/matx-react/node_modules/grpc/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build" "--library=static_library"
node-pre-gyp ERR! cwd /Users/h/dev/haf/matx-react/node_modules/grpc
node-pre-gyp ERR! node -v v14.2.0
node-pre-gyp ERR! node-pre-gyp -v v0.13.0
node-pre-gyp ERR! not ok

Last bit of compiler error:

  LIBTOOL-STATIC Release/libaddress_sorting.a
  CXX(target) Release/obj.target/grpc_node/ext/byte_buffer.o
  CXX(target) Release/obj.target/grpc_node/ext/call.o
../ext/call.cc:104:53: error: no matching member function for call to 'Get'
    Local<String> current_key(Nan::To<String>(keys->Get(i)).ToLocalChecked());
                                              ~~~~~~^~~

Repro

  1. Clone repo
  2. npm i

I have everything brew-installed, with latest versions at time of writing.

Saivivek-Peddi commented 4 years ago

Try this - https://github.com/grpc/grpc-node/issues/1183#issuecomment-596956959 it worked.

eladcandroid commented 4 years ago

Please implement this solution on the repo - I've created a PR for that: https://github.com/uilibrary/matx-react/pull/8

mh-rafi commented 3 years ago

updated the package and the issue is fixed :)