Closed dependabot[bot] closed 10 months ago
Assuming the auth error gets fixed for GH Actions, This PR introduced quite a few changes and bring it up to speed with the current standards along with updating to Spring boot 3. The following significant changes have been made:
Given that these may not be 1:1 changes, we should run the E2E test first before merging.
e2e test did not pass wilth all other service being latest (seems to be issue with CEGA auth), but that could be that the rewrite in this branch changed a previous mechanism for the test to avoid CEGA NSS on upload). I will try to test also with my different setup (not using that additional mechanism, but the regular CEGA NSS auth):
2023-09-13 05:50:04.187 INFO 1 --- [nio-8080-exec-6] no.uio.ifi.ltp.aspects.AAIAspect : Cannot invoke "no.uio.ifi.ltp.dto.ResultsHolder.getCredentials()" because the return value of "no.uio.ifi.ltp.dto.ResponseHolder.getResultsHolder()" is null
java.lang.NullPointerException: Cannot invoke "no.uio.ifi.ltp.dto.ResultsHolder.getCredentials()" because the return value of "no.uio.ifi.ltp.dto.ResponseHolder.getResultsHolder()" is null
at no.uio.ifi.ltp.authentication.CEGACredentialsProvider.getCredentials(CEGACredentialsProvider.java:53) ~[classes!/:0.0.1-SNAPSHOT]
at no.uio.ifi.ltp.authentication.CEGACredentialsProvider$$FastClassBySpringCGLIB$$1e644983.invoke(<generated>) ~[classes!/:0.0.1-SNAPSHOT]
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:783) ~[spring-aop-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) ~[spring-aop-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) ~[spring-aop-5.3.17.jar!/:5.3.17]
at org.springframework.cache.interceptor.CacheInterceptor.lambda$invoke$0(CacheInterceptor.java:54) ~[spring-context-5.3.17.jar!/:5.3.17]
at org.springframework.cache.interceptor.CacheAspectSupport.invokeOperation(CacheAspectSupport.java:366) ~[spring-context-5.3.17.jar!/:5.3.17]
at org.springframework.cache.interceptor.CacheAspectSupport.execute(CacheAspectSupport.java:421) ~[spring-context-5.3.17.jar!/:5.3.17]
at org.springframework.cache.interceptor.CacheAspectSupport.execute(CacheAspectSupport.java:345) ~[spring-context-5.3.17.jar!/:5.3.17]
at org.springframework.cache.interceptor.CacheInterceptor.invoke(CacheInterceptor.java:64) ~[spring-context-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) ~[spring-aop-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) ~[spring-aop-5.3.17.jar!/:5.3.17]
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:698) ~[spring-aop-5.3.17.jar!/:5.3.17]
at no.uio.ifi.ltp.authentication.CEGACredentialsProvider$$EnhancerBySpringCGLIB$$7af5990.getCredentials(<generated>) ~[classes!/:0.0.1-SNAPSHOT]
at no.uio.ifi.ltp.aspects.AAIAspect.cegaAuth(AAIAspect.java:126) ~[classes!/:0.0.1-SNAPSHOT]
at no.uio.ifi.ltp.aspects.AAIAspect.authenticateCEGA(AAIAspect.java:113) ~[classes!/:0.0.1-SNAPSHOT]
The StackTrace above is from the proxy server log (not the e2e test code stack trace).
When testing the service on the tryggve server, using regular EGA username/password and ELIXIR_AAI_TOKEN, and run the new e2e test in a docker container from the tryggve server, I get the same stack trace in PROXY_proxy logs... So there seems to be something not working for real.
@dependabot rebase
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!
If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate
.
A newer version of org.springframework.boot:spring-boot-starter-parent exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.
Already done and merged in.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore
condition with the desired update_types
to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps org.springframework.boot:spring-boot-starter-parent from 2.7.8 to 3.1.3.
Release notes
Sourced from org.springframework.boot:spring-boot-starter-parent's releases.
... (truncated)
Commits
9edc772
Release v3.1.35981252
Merge branch '3.0.x' into 3.1.x75f1604
Merge branch '2.7.x' into 3.0.xa1cd7e7
Upgrade to Spring Batch 5.0.34e6de6c
Upgrade to RxJava3 3.1.799a5543
Upgrade to Netty 4.1.97.Finaldf85c81
Upgrade to Spring Batch 5.0.34c719c1
Upgrade to RxJava3 3.1.748e3eba
Upgrade to Netty 4.1.97.Final25897b2
Upgrade to Spring Batch 4.3.9Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show