Closed quamsta closed 2 years ago
I think this button needs an outline, especially in the modal. Maybe remove the line above and add the outline? I think we need to adjust the color of the outline in UIDS.
We probably need to adjust the button in UIDS to allow for a white background and border as well.
@bspeare I agree, we should probably do outlines! And that the border and background colors may need to be adjusted to work better on white/gray backgrounds.
I pushed up a couple of changes that include:
#ccc
Those last two items may make good candidates for UIDS, possibly?
@bspeare I'm also coming around to sharper card-like borders on the icon buttons... Now that we have these sharper borders on the buttons, the softer borders seem a bit out of place
@quamsta I think that looks good. Is it worth creating a quick pr in UIDS to make these updates for the last two items? It would be cool to get those in there before we forget.
@bspeare Probably a good call, I don't know how quick I can do it, since I haven't done any PR work in UIDS like, ever and I wanna make sure it's done right. Unless you want to? :P
@quamsta I could start something. I'll check in with you before I do.
@bspeare Sounds good, I think an overarching button style change/addition may be better in your hands :)
@quamsta I started something in https://github.com/uiowa/uids/pull/711 that I will continue to work on.
Resolves #27
I've switched over from a custom component to using the UIDS 4.x button component (tertiary style):