search

uiowa / brand-icon-browser

0 stars 1 forks source link

gh-pages branch contains old CSS and JS builds #77

Closed quamsta closed 2 years ago

quamsta commented 2 years ago

Not sure if this is intentional, but each time the webapp is built and deployed to the gh-pages branch, it looks like the js/ and css/ folders aren't cleared out and consequently, these folders are starting to fill with older, unused builds of the web app:

https://github.com/uiowa/brand-icon-browser/tree/gh-pages/js https://github.com/uiowa/brand-icon-browser/tree/gh-pages/css

@pyrello -- We're using the same build process that the viewbooks use: https://github.com/uiowa/admissions-viewbook, and those repos are exhibiting the same issue.

Could this be resolved somehow by clearing out these directories in https://github.com/uiowa/brand-icon-browser/blob/main/.github/workflows/gh-pages.yml during the deploy process?

pyrello commented 2 years ago

@quamsta This seems to be a problem specifically with out the main app (as opposed to latest) is getting built. It is copying in files and not doing any blanket delete because that would remove files we want. Possibly we could just add a step to remove the contents of those specific folders before the cp step.

quamsta commented 2 years ago

Working on a PR for this... Would appreciate a review when it's ready

quamsta commented 2 years ago

@pyrello Any chance you could take a look at the PR?

https://github.com/uiowa/brand-icon-browser/pull/78