uiowa / uids

UI Design System
http://uids.brand.uiowa.edu
7 stars 1 forks source link

Feature table updates #735

Closed bewoldt closed 2 years ago

bewoldt commented 2 years ago

Fix for #705

Adds a border top back when using the table--gray-borders class. The only issue I've seen with this is when you have a caption that has the class "element-invisible" the top border doubles up. I don't see this as an issue since it is impossible for a user to add this class to a caption in the wysiwyg editor.

I also set a default line-height for tables to be the default body line-height which is 1.15. I noticed that tables created in the main body content area had a line-height of 1.7 but tables created within a component like the Text Area or Collection have 1.15. The main body content table are getting a line-height set by a class ".text-formatted div" of 1.7. I'm open to ideas on what the default should be but I set it as 1.15 for now.

bewoldt commented 2 years ago

sandbox page with some tables. https://sandbox.prod.drupal.uiowa.edu/more-tables