Closed bspeare closed 9 months ago
I guess I had missed that this was in progress and was so far along. Nice work on this so far. I think we need to refine how we are thinking about the variations (what is changing) and possibly split the properties to reflect that, but otherwise this is looking really good.
Some thoughts for next steps after this:
headline_style
) on components (CTA, Card) for nested components (Headline) doesn't scale very well. That is, it introduces a lot of redundancy because each component that implements a property to pass through to the nested component has to have essentially the same property as the nested component. For the headline example, this means that every component that implements the headline component needs to have a headline_text_style
, headline_underline
, and headline_highlight
property that is the same as the relevant properties on the headline component. If we make changes to the logic of how the headline component works, we have to propagate those changes throughout all the parent component properties as well.
Resolves https://github.com/uiowa/uids/issues/782. Resolves https://github.com/uiowa/uids/issues/897.