search

uiowa / uids

UI Design System
http://uids.brand.uiowa.edu
7 stars 1 forks source link

Slider img has fixed height on larger displays #760

Open bspeare opened 2 years ago

bspeare commented 2 years ago

Problem

There is a fixed height on the slider img: https://github.com/uiowa/uids/blob/3.x/src/components/slider/slider.scss#L68

Screen Shot 2022-08-29 at 8 37 33 AM

Proposed solution

Can we remove it?

joewhitsitt commented 2 years ago

You tell me ;) https://github.com/uiowa/uids/commit/c1bc29cab3533232fb7d5387f36cb848a7cbaa33

bspeare commented 1 year ago

The fixed height also is causing overflow issues: https://github.com/uiowa/uiowa/issues/5472#issuecomment-1347257164.