search

uiowa / uids

UI Design System
http://uids.brand.uiowa.edu
7 stars 1 forks source link

Callout component 4.x #845

Closed bspeare closed 1 year ago

bspeare commented 1 year ago

Resolves https://github.com/uiowa/uids/issues/844

pyrello commented 1 year ago

I think we are going to leave this in draft to keep it open in case there are additional changes needed for uiowa/uiowa#6074.

GaryRidgway commented 1 year ago

My most recent commit should find things that are only children and inherit their sizing to the previous sizing before the column styles. This should cover the edge cases for there only being an image in a text area. If we do not want it, please feel free to remove it.

pyrello commented 1 year ago

My most recent commit should find things that are only children and inherit their sizing to the previous sizing before the column styles. This should cover the edge cases for there only being an image in a text area. If we do not want it, please feel free to remove it.

Does this solve a problem in UIDS? Or is it a SiteNow thing? If it solves a problem for UIDS, then I would like to see something in the inline storybook story to show what it is doing. However, it sounds like maybe this is a layout builder edge case, @bspeare?

GaryRidgway commented 1 year ago

It is an edge case that could occur in uids as well, but you are correct, I didn't make a story for it. While we are reassessing, we can decide if it stays or not or if we need to make a story for it.

GaryRidgway commented 1 year ago

I had a neat idea to try and make a function to parse our column classes to output labels, but the @pyrello on my shoulder told me it may have been too much. I have enshrined it in this compare statement so we can look at what it would do if we ever wanted to use it in the future!

GaryRidgway commented 1 year ago

On first glance, the videos really don't want to grow in height...

GaryRidgway commented 1 year ago

~Seems like we need to adjust to allow remote videos and whatnot not be mapped. Blargh.~

Not sure what keeps happening, but I am obviously having a hard time keeping everything in this PR straight, lol. Don't think this is an issue.