search

uiowa / uids

UI Design System
http://uids.brand.uiowa.edu
7 stars 1 forks source link

4.x Alerts #889

Closed e-marie-w closed 10 months ago

e-marie-w commented 10 months ago

Resolves #770.

bspeare commented 10 months ago

These are all resolved now

Noticing the sizing difference between `Lorem ipsum sit dolor amet.

Lorem ipsum sit dolor amet.

` can we get the text without `

` to render the same as the text with `

` markup? Also, can we increase the icon size to like `.alert .fa-1x {font-size: 1.5em;}` With the `

` having extra bottom margin, the vertically centered icon will need to be evaluated. Screenshot 2023-08-17 at 9 31 37 AM Same issue with just a paragraph: Screenshot 2023-08-17 at 9 34 35 AM Could be solved by `.alert p + p {margin-top: 1.05rem;}` type rule. Update: This will also need to be done for heading tags as well.

bspeare commented 10 months ago

I'm finished with my review. This looks great to me and I will leave this open in case others want to review.