uiowa / uids

UI Design System

http://uids.brand.uiowa.edu

7 stars 1 forks source link

[UIHC] Brand bar #925

Closed bspeare closed 1 month ago

bspeare commented 1 month ago

How to test

yarn storybook

Code review
Test uihc boolean on logo and brand bar stories
- http://localhost:6006/?path=/story/components-branding-logo--default&args=uihc:!false
- http://localhost:6006/?path=/story/components-branding-brand-bar--default
- Confirm that gold brand bar gets taller to make room for UIHC logo
- Confirm that uihc variant displays as expected for all breakpoints

Notes:

Sticky header CSS was moved out of brand-bar.scss to uids_base since that is where the JavaScript for that implementation lives.
base/reset was moved to the first line of uids-core.scss by request of Dustin Quam.

pyrello commented 1 month ago

Pulling to test.