Closed zmorris248 closed 7 months ago
It seems that sonarcloud doesn't like the duplicated code that is in our testing suite. I think that we either need to adjust its expectations or figure out how to exclude certain libraries from its analysis. Thoughts?
It seems that sonarcloud doesn't like the duplicated code that is in our testing suite. I think that we either need to adjust its expectations or figure out how to exclude certain libraries from its analysis. Thoughts?
We can probably use a fixture or something similar I will look into it.
It seems that sonarcloud doesn't like the duplicated code that is in our testing suite. I think that we either need to adjust its expectations or figure out how to exclude certain libraries from its analysis. Thoughts?
We can probably use a fixture or something similar I will look into it.
added a fixture should be good now
Issues
10 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code
Overview
This pull request merges our work on refactoring the job_monitoring_application to refer to 'studies' instead of 'jobs'. It includes a renaming of all references to a 'job' to a 'study' in the frontend, backend, and trackerapi as well as the orthanc_data_logger that uses trackerapi.
Migrations were run to change the event table column 'job_id' to 'study_id', add the 'studies' table to the db, and delete the 'jobs' table.
These refactorings make our app more coherent and are more in line with real world medical imaging applications.
Implementation
Testing
All tests related to 'jobs' were either changed or rewritten to test the 'studies' in all modules of the application.
Problems Faced
Figuring out the best way to make incremental changes in the right order was challenging at first. Our initial attempt at this failed, but we learned from it and adapted. The process we found to be the best:
Notes
Closes #113