Closed mbrzus closed 7 months ago
Quality Gate failed
Failed conditions 45.0% Duplication on New Code (required ≤ 3%)
@Ivan-E-Johnson @zmorris248 @powersaudrey25 the new example_tool_light is a copy of example_tool with limited functionality. For the purpose of easy switching between the two (which will be important especially in the AWS deployment) I propose to ignore the SonarCloud error
I agree with Michal on ignoring the sonarcloud error. This looks good Michal!
@mbrzus @zmorris248 I dont see a way on sonar cloud to disable the check so we may need to do this on github. Do you want me to disable the rule on github merge and then reenable it?
@Ivan-E-Johnson I think that is the best way to go about this since it is a unique situation. I didn't find an easy way to do it either.
I created a new quality gate on sonarcloud that doesn't check for duplication I am go to try and run this pr with it now
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
35.0% Duplication on New Code
I created a new quality gate on sonarcloud that doesn't check for duplication I am go to try and run this pr with it now
we can switch back to our other quality gate whenever we want
@mbrzus When I build the exampletool light docker and run the script to run it, I get the following error: docker: Error response from daemon: pull access denied for brainmasktool, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
Do you know what this could be?
@mbrzus When I build the exampletool light docker and run the script to run it, I get the following error: docker: Error response from daemon: pull access denied for brainmasktool, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
Do you know what this could be?
I will need more info. do you run the docker only or are you running it from within the Orthanc Receiver Agent?
Overview
This pull requests creates "light" version of the example tool to reduce the environment dependencies from 6.7 GB to 849 MB.
Currently, the tool still performs the DICOM data checking and sanitization but produces empty report. However, it still encodes the report to the DICOM format thus maintaining the full functionality from data types and delivery items.
This changed required restructurization of the repo by moving the example data to the base level to avoid duplicating it.
Implementation
Testing
Testing should be performed the same way as the example_tool
Closes #129