uiowaSEP2024 / 002_ImagePro

Image processing backend
1 stars 0 forks source link

114 update job configurations to study configurations #137

Closed powersaudrey25 closed 5 months ago

powersaudrey25 commented 6 months ago

Overview

!!!! Waiting to merge until bug is fixed in main

This pull request merges our work on refactoring the job_monitoring_application to refer to 'study_configuration' instead of 'job_configuration'. It includes a renaming of all references to a 'job_configuration' to a 'study_configuration' in the frontend, backend, trackerapi, and internal_servers.

The following migrations were created:

These refactorings make our app more coherent and are more in line with real world medical imaging applications.

Implementation

Migrations to the database Refactoring in frontend, backend, trackerapi, and internal_servers

Testing

All tests related to job_config were changed to reference study_config. All tests in backend, trackerapi, and frontend pass. All Cypress tests pass.

Problems Faced

I had accidentally changed a step configuration reference to a study config reference which broke a lot of tests. After fixing that though no other significant problems since I followed the procedure outlined in PR 113

Notes

No visible frontend changes.

github-actions[bot] commented 6 months ago

Jest Coverage

Summary

Lines Statements Branches Functions
Coverage: 75%
75.65% (432/571) 57.14% (68/119) 68.2% (118/173)

Junit Summary

Tests Skipped Failures Errors Time
35 0 :zzz: 0 :x: 0 :fire: 3.666s :stopwatch:
Coverage Report (75%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files75.6557.1468.275.14 
fixtures100100100100 
   kidneyStudyFixture.tsx100100100100 
src/components90.0944.4482.7591.17 
   ErrorMessageBox.tsx83.331000100 
   EventTimeline.tsx71.42007579–83
   Metadata.tsx85.7108084.6174–75
   Navbar.tsx90.475010090150, 163
   StackedChart.tsx10066.6610010072–85
   withAuthenticated.tsx100100100100 
src/contexts9010058.3389.28 
   authContext.tsx9010058.3389.2872, 90, 104
src/data28.0828.5736.1116.88 
   index.ts28.0828.5736.1116.8814–24, 35–45, 53–63, 73–83, 95–104, 116–126, 136–145, 155–160, 172–189, 199–207, 217–222, 235–274
src/hooks100100100100 
   useAuthContext.ts100100100100 
src/pages86.8477.4183.3387.5 
   analytics.tsx96.1510088.889690
   dashboard.tsx100100100100 
   index.tsx100100100100 
   login.tsx83.8788.8885.7183.3352–57, 109
   profile.tsx78.5766.667583.3363–66
   signup.tsx80.4857.1472.728065–67, 82–83, 163–170, 194
src/pages/apikeys73.2154.5464.2871.69 
   index.tsx73.2154.5464.2871.6974–77, 89, 94–99, 104–108, 195
src/pages/studies75.2347.2267.7478.12 
   [id].tsx68.5737.557.8971.4284, 93–107, 111–113, 124–125, 129, 133, 142, 218
   index.tsx88.5766.6683.3390.969, 78, 95
sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

powersaudrey25 commented 6 months ago

@mbrzus Michal I know you were running into some problems with the agent/logger, was that related to this PR or is this fine to merge? @zmorris248 were you able to run the agent/logger and create a job with this PR?

mbrzus commented 6 months ago

@mbrzus Michal I know you were running into some problems with the agent/logger, was that related to this PR or is this fine to merge? @zmorris248 were you able to run the agent/logger and create a job with this PR?

Yes, I was getting issues on this branch, I described them on teams (conversation on March 8th).

zmorris248 commented 6 months ago

@powersaudrey25 When I ran it with you on the last day before break, I did see some information on the Orthancs already, related to @mbrzus's first issue on teams. This didn't affect me running the system though or the agent. I could see things getting updated on the front end. I would get an error on step 4, as I think everyone else is. I believe it would keep re-running the study because step 4 was never marked as completed, so our system finishes the process and still finds a study in queue and restarts the process.

powersaudrey25 commented 6 months ago

@mbrzus @zmorris248 thanks! just wanted to get the problems documented on this branch/pr