powersaudrey25 commented 5 months ago

Overview

We no longer want providers to have the ability to generate api keys. We also need set the API key as an environment variable in the receiver agent

Implementation

The following was implemented:

removal of 'Generate API Keys' from frontend for providers
unless you are a logged in admin you cannot navigate to /apikeys
new tests that verify trying to navigate to /apikeys with a hospital or provider role throws a 401
api key is now pulled from environment file in receiver agent

Testing

This was manually tested via docker compose and spinning up Orthancs locally. I was able to log in and kickoff a study in the agent. Everything worked as it should. I logged in as a provider and a hospital user and verified I could not access the /apikeys page. Cypress tests were updated and all pass as well as frontend and backend.

Problems Faced

Notes

Current provider view:

Current admin view:

github-actions[bot] commented 5 months ago

Jest Coverage

Summary

Lines	Statements	Branches	Functions
	74.87% (438/585)	57.14% (68/119)	68.57% (120/175)

Junit Summary

Tests	Skipped	Failures	Errors	Time
35	0 :zzz:	0 :x:	0 :fire:	3.783s :stopwatch:

Coverage Report (74%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	74.87	57.14	68.57	74.25
fixtures	100	100	100	100
kidneyStudyFixture.tsx	100	100	100	100
src/components	90.09	44.44	82.75	91.17
ErrorMessageBox.tsx	83.33	100	0	100
EventTimeline.tsx	71.42	0	0	75	79–83
Metadata.tsx	85.71	0	80	84.61	74–75
Navbar.tsx	90.47	50	100	90	150, 163
StackedChart.tsx	100	66.66	100	100	72–85
withAuthenticated.tsx	100	100	100	100
src/contexts	90	100	58.33	89.28
authContext.tsx	90	100	58.33	89.28	72, 90, 104
src/data	30.09	28.57	39.47	20
index.ts	30.09	28.57	39.47	20	17–27, 38–48, 56–66, 76–86, 98–107, 119–129, 139–148, 158–163, 175–198, 209–217, 227–232, 245–284, 300–301
src/hooks	100	100	100	100
useAuthContext.ts	100	100	100	100
src/pages	86.84	77.41	83.33	87.5
analytics.tsx	96.15	100	88.88	96	90
dashboard.tsx	100	100	100	100
index.tsx	100	100	100	100
login.tsx	83.87	88.88	85.71	83.33	52–57, 109
profile.tsx	78.57	66.66	75	83.33	63–66
signup.tsx	80.48	57.14	72.72	80	65–67, 82–83, 163–170, 194
src/pages/apikeys	73.21	54.54	64.28	71.69
index.tsx	73.21	54.54	64.28	71.69	74–77, 89, 94–99, 104–108, 195
src/pages/studies	75.23	47.22	67.74	78.12
[id].tsx	68.57	37.5	57.89	71.42	84, 93–107, 111–113, 124–125, 129, 133, 142, 218
index.tsx	88.57	66.66	83.33	90.9	69, 78, 95