Ivan-E-Johnson commented 6 months ago

Overview

This pull request mergers the trackerapi module with our orthanc logging agents. The orthanc logger agent is now configured to take in arguments for the user in the database and the job being sent to the database and uses trackerapi to send those to the backend upon initialization. There is also functionality added to implement updating an event, as all events will be sent as incomplete initially and then their status will be changed as they are completed. This functionality is still not complete and is being tested.

Naming conventions across modules are different and need to be modified. This will expedite enhancements and make maintenance much more efficient. Proposed changes: step and event have essentially the same meaning and one needs to be picked for homogenization.

Implementation

Tracker api functionality was imported into orthanc_data_logger.py. It was then used to create a job in the backend and send the events of that job upon initialization using the current tracker api functions. New trackerapi functions for updating current events are there but not fully implemented. As these pieces are completed, our orthanc logging agents should be able to interact with the database upon interaction with outside agents such as hospitals and providers

Testing

Manual tests were done on Zach and Ivan's local environments. See screenshots below

Problems Faced

Integrating the api module into the orthanc loggers encountered issues, we were unable to import the trackerapi functionality until we soft linked it into our site-packages
Naming conventions are very confusing for tracking code across modules, this needs to be a separate issues made
Major refactorizations to the db need to happen, including naming conventions, jobs table, events table, and users table

Notes

closes #80 closes #91 closes #94

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
138 New issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

Ivan-E-Johnson commented 6 months ago

@mbrzus @zmorris248 @powersaudrey25 This is now the version that we should cleanup and ensure passes Sonar CI. I gave up fixing the imports its just going to be messy and we can add a W5 or W8 Issues about fixing the imports but that is its own PR.

zmorris248 commented 6 months ago

Sounds good, will work on it now

uiowaSEP2024 / 002_ImagePro