search

uiri / SEGIMAP

IMAP (and LMTP) Server written in Rust
MIT License
32 stars 6 forks source link

Improve error handling, replace rustc_serialize, add minor test-case fixes #22

Closed indiv0 closed 7 years ago

indiv0 commented 7 years ago

The bulk of this PR is a re-write of our error system, as described in #15, and originally attempted on this branch. Since that branch has since gotten very stale, this PR does not build upon it but was instead written from scratch. Note that this PR does not close #15, as many unwrap()s still exist in the code. Some errors have been improved to use proper error variants instead of strings attached to a generic error, but this can be taken further in future PRs.

This PR also replaces all usages of rustc_serialize with serde_json, closing #19.

Additionally this PR fixes some minor issues related to test cases and the unstable feature.

This change is Reviewable

uiri commented 7 years ago
:lgtm:

Reviewed 14 of 14 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable