uiri / SEGIMAP

IMAP (and LMTP) Server written in Rust
MIT License
32 stars 6 forks source link

Crates #30

Closed uiri closed 7 years ago

uiri commented 7 years ago

This change is Reviewable

indiv0 commented 7 years ago
:lgtm:

Reviewed 60 of 60 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


.travis.yml, line 25 at r1 (raw file):

after_success:
- (cd core && ../.travis-cargo-after.sh);
- (cd mime && ../.travis-cargo-after.sh);

My concern here is that we end up running the doc-upload command twice. Will this overwrite the core docs with the mime docs? I don't think we can test this right now because rust will only create docs for a library, not a binary.


Comments from Reviewable

uiri commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.


.travis.yml, line 25 at r1 (raw file):

Previously, indiv0 (Nikita Pekin) wrote…
My concern here is that we end up running the doc-upload command twice. Will this overwrite the core docs with the mime docs? I don't think we can test this right now because rust will only create docs for a library, not a binary.

I'm not really sure. I don't see any docs anywhere so if we end up with docs for the mime crate, that is strictly better than what we have now.


Comments from Reviewable