Refactor - Githubissues

uiri / SEGIMAP

IMAP (and LMTP) Server written in Rust

MIT License

32 stars 6 forks source link

Refactor #34

Closed uiri closed 7 years ago

uiri commented 7 years ago

Folder more idiomatic/cleaned up a bug or two
Reorganize the user module as part of the server module. Separated out user::session.
Rename session to imap and Session to ImapSession
Refactor listen loops in main
Rename Command to FetchCommand and remove the CommandType because only one type - Fetch - exists.
Minor cleanup here and there inside command submodules

This change is

indiv0 commented 7 years ago

I'm a little bit unsure on the removal of CommandType because we'll probably need it once we start adding support for other commands. Do we want to take it out just to put it back in later? Then again, I guess since we're not actually using it now there's no need to have that functionality as it just complicates the code right now. I assume that was your reasoning?

Other than that, PR looks good.

Reviewed 19 of 19 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

indiv0 commented 7 years ago

I decided to just go ahead and merge this. We're not using CommandType functionality right now, and if necessary we can just add it back in later.