search

uiuc-hpc / Recorder

Multi-level I/O tracing library
Other
43 stars 14 forks source link

removed unwrapped real function decls #3

Closed HenryYihengXu closed 3 years ago

HenryYihengXu commented 3 years ago

Here are the MPI functions that have the __real_func declaration in recorder.h but don't have the corresponding wrapper in recorder-mpi.c:

  1. MPI_Wtime
  2. MPI_Type_contiguous
  3. PMPI_Type_extent
  4. PMPI_Type_free
  5. PMPI_Type_hindexed
  6. PMPI_Op_create
  7. PMPI_Op_free
  8. PMPI_Type_get_envelope
  9. PMPI_Type_size
  10. PMPI_Sendrecv
  11. PMPI_Info_set
  12. PMPI_Info_set

Also, the wrappers of MPI_Init, MPI_Init_thread, and MPI_Finalize are not in recorder-mpi.c but in recorder-mpi-init-finalize.c. Should we move them to recorder-mpi.c? And they are not defined with RECORDER_MPI_DECL, which I think is a bug. Should we fix this?

Minor: I added RECORDER_MPI_DECL to MPI_Allgather wrapper in recorder-mpi.c

wangvsa commented 3 years ago

MPI_Sendrecv does exist. Please add this back. Everything else is fine.

MPI_Init*, and MPI_Finalize are put into a separate file on purpose. They perform special initialization/finalization tasks. And yes, I should wrap them with RECORDER_MPI_DECL. But this has no impact when using LD_PRELOAD.

HenryYihengXu commented 3 years ago

Sorry that was a typo. I meant MPI_Info_create. I didn't remove PMPI_Sendrecv