search

uiuc-mrdc / cogs

Containerized Game Services
3 stars 0 forks source link

Added CoGS for Dummies #2

Closed lpulley closed 5 years ago

lpulley commented 5 years ago

Minor changes to the README. Will have to update the "Dummies" section as we add services. Also, @Timur2012, when cloning the repo and running from scratch, will the user need to run docker-compose exec web python manage.py makemigrations in addition to migrate, to create migrations from our custom models?

mgale456 commented 5 years ago

Normally you'd run both commands for a new project. However, makemigrations just makes a file. Since anyone using this is downloading the repo, the migration file could already be made and just migrating works. I just tried tried it. You can probably run the command from that dockerfile.

On that topic, we need to make an app instead of putting our models and stuff inside the project folder

lpulley commented 5 years ago

@mgale456 I'm always down to do things properly. I'll have to look into making things into apps in Django, since I'm not familiar, but you should definitely give it a go. You should create a branch off of team-management and convert the existing work into an app (just as soon as @Timur2012 pushes the branch here). I'll make sure you're a contributor. When you're done you can submit a pull request from your branch back onto team-management.

If you agree with my README changes you're welcome to approve this merge for me!

lpulley commented 5 years ago

Hahaha it says @mgale456 approved 1 hour ago, and has the check mark by your name, but still says it needs 1 approving review...hm. Let me know if you figure it out. I think we're just missing something silly.

lpulley commented 5 years ago

Oh @mgale456 make sure you accept my invitation to be a member of uiuc-mrdc! I think it's not counting your review because you're not officially in the organization.

mgale456 commented 5 years ago

image This is why I'm not in the organization. The invite got cancelled. Please reinvite.

lpulley commented 5 years ago

Weird, I didn't cancel it. Sent another just now.

lpulley commented 5 years ago

I'm going to leave the README branch open. Usually it's good to delete branches once their changes are in, but I intentionally made readme as an all-purpose branch for just README.md. Let's not do this with Django, though, that's a much bigger scope.