uiuc-mrdc / cogs

Containerized Game Services
3 stars 0 forks source link

Judging page fixes #20

Closed mgale456 closed 4 years ago

mgale456 commented 4 years ago

The features of the judging page are complete. The Scoring branch has also been rolled into this. Please test it, and recommend other things to add. The beautification is definitely not done, and if someone else wants to give that a shot, that'd be great.

It handles everything that the old one did afaik, and functions very similarly.

Non-exhaustive list of features:

  1. Easy to add new buttons to the page by using the Django admin site
  2. Supports any number of teams
  3. Scoring supports changing the multiplier in the middle of the match, and preserving the multiplier on previous points earned
  4. The counter arrows also support typing for input to the db (the multiplier for these is scored based on the multiplier at the time of the last update)
  5. The delete buttons at the bottom do not actually delete the db row. They just change a boolean
  6. Inputs are blocked from sending to the db if a team is not selected, the game hasn't been started, or the game is already finalized
  7. Supports non-linear scoring (like Brewing Potions). Last year we would have needed 3 buttons just for that.
  8. It has all the features of the old one
lpulley commented 4 years ago

Trying to test this but I can't seem to find how to select a team?

mgale456 commented 4 years ago

Click a team name at the top of the page. We can improve the clarity with some css. Right now the chosen team is Bolded.

On Fri, Feb 28, 2020, 7:59 PM Logan Pulley notifications@github.com wrote:

Trying to test this but I can't seem to find how to select a team?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uiuc-mrdc/cogs/pull/20?email_source=notifications&email_token=ANIYCQ2GEW52BASBR26PLVDRFG6QTA5CNFSM4K4UP2N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKZQHY#issuecomment-592812063, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANIYCQ636G3HLT4KJZPVVZ3RFG6QTANCNFSM4K4UP2NQ .

lpulley commented 4 years ago

Sorry I've been so absent on this!!!! I'm testing this now and will approve when done.