search

uiucsn / astro_ghost

Galaxies HOsting Supernovae and other Transients (GHOST): A database of supernovae and the photometric and spectroscopic properties of their host galaxies.
2 stars 6 forks source link

Separate phot-z prediction from panstarrs querying in calc_photoz #8

Closed hombit closed 2 years ago

hombit commented 2 years ago

Previously calc_photoz did a lot of things: 1) queried Pan-STARRS archive to get photometry data, 2) loads SFD and model from the web, 3) evaluated model, 4) prepared results. This PR separates 2) and 3) into get_photoz (hm, not the best name) which allows to use custom dataframe with Pan-STARRS forced photometry data. I see multiple use cases for this: simulated data, objects which do not pass constraints (for example there could be objects user believes are real, but nDetections <= 1), etc

hombit commented 2 years ago

Thank you! Looks like GitHub Action failures are not related to this contribution

alexandergagliano commented 2 years ago

@hombit @awe2 Finally closing the loop on this (sorry for the delay!) -- we should connect up with David Jones and Dave Coulter to make sure that YSE PZ is still generating photo-zs correctly after this change.