uiuniversal / ngu-carousel

Angular Universal carousel
https://ngu-carousel.netlify.app
MIT License
332 stars 105 forks source link

🐞 Missing `@angular/animations` in `peerDependencies` #437

Closed Yberion closed 1 year ago

Yberion commented 1 year ago

Describe the bug

Missing @angular/animations in package.json from the lib.

I think it require to add "@angular/animation": "^15.0.0"

I tested with 7.0.0 and it works as expected.

To Reproduce

Try to use 7.1.1 on a fresh project which use latest Angular version (15.2.7).

npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/animations@"15.0.2" from @ngu/carousel@7.1.1
npm ERR! node_modules/@ngu/carousel
npm ERR!   @ngu/carousel@"~7.1.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:

Expected behavior

No error when installing the version 7.1.1.

Desktop (please complete the following information):

Additional context

Angular: 15.2.7 carousel: 7.1.1

Would you like to open a PR (Support will be provided): [x] Yes [ ] No

cc @santoshyadavdev, I can make a PR to fix the issue.

santoshyadavdev commented 1 year ago

Thank you for Reporting, yes please go ahead with the PR

santoshyadavdev commented 1 year ago

Released with 7.1.2

Yberion commented 1 year ago

Works fine!

I did set zone.js version in the lib which I think was not a good idea (the versioning on zone.js is different), I will make a PR to solve that or perhaps @arturovt can do that ?

santoshyadavdev commented 1 year ago

Thank you Brandon, I can do this quickly

Yberion commented 1 year ago

That is awesome, thanks a lot Santos!