uiuniversal / ngu-carousel

Angular Universal carousel

https://ngu-carousel.netlify.app

MIT License

326 stars 105 forks source link

chore: update README.md #440

Closed arturovt closed 1 year ago

arturovt commented 1 year ago

We explicitly import hammerjs in the code through the dynamic import so this cannot be an optional dependency.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 868feffd10be493964362626bb65d3c2237375cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

- [`nx run-many --target=build --all`](https://cloud.nx.app/runs/nDLssEeJ8p)

Sent with 💌 from NxCloud.

Yberion commented 1 year ago

Hello @arturovt, if we set touch to false it should not load it since it's a dynamic import, meaning that we installed that dependencie for nothing if we don't need touch, maybe I'm wrong ^^

https://github.com/uiuniversal/ngu-carousel/blob/master/libs/ngu/carousel/src/lib/ngu-carousel/ngu-carousel.component.ts#L298