search

uiuniversal / ngu-carousel

Angular Universal carousel
https://ngu-carousel.netlify.app
MIT License
331 stars 105 forks source link

fix: set _unwrappedData to _dataSource f its not a stream #457

Closed santoshyadavdev closed 4 months ago

santoshyadavdev commented 1 year ago

@arturovt this is related to https://github.com/uiuniversal/ngu-carousel/issues/453 is this what you meant?

@chivesrs can you try this commit.

NOTE: it looks broken , let me check

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 44bc9f6b14ddcd9b652213a9041cd1d893e0a5f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/C9LDeUhfzI)

Sent with 💌 from NxCloud.

chivesrs commented 1 year ago

It does not work unfortunately. It's worse now, in the previous version I could make things happen by tabbing to the "next" button and then the carousel would render. Now even that doesn't happen.

github-actions[bot] commented 4 months ago

This PR has been automatically marked as stale because it has not had recent activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

Closing this PR due to no activity for 6 months.