search

uiuniversal / ngu-carousel

Angular Universal carousel
https://ngu-carousel.netlify.app
MIT License
326 stars 105 forks source link

FIX: content duplication on async carousels #458

Closed luca-peruzzo closed 1 year ago

luca-peruzzo commented 1 year ago

With the previous version when the dataSource input was async and had an element count less than the displayed grid, there was a duplication of elements (you can test it with your example app, setting take(3) to tile.component.ts in a viewport that supports 5 tiles).

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a3b7f50844a3e3133b59f00b65d65d5fb6bb736f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/KOwTna8wD7)

Sent with 💌 from NxCloud.

santoshyadavdev commented 1 year ago

Thank you for the PR

santoshyadavdev commented 1 year ago

Adds @luca-peruzzo as a contributor for code.

santoshyadavdev commented 1 year ago

@all-contributors please add @luca-peruzzo for code

allcontributors[bot] commented 1 year ago

@santoshyadavdev

I've put up a pull request to add @luca-peruzzo! :tada:

luca-peruzzo commented 1 year ago

@santoshyadavdev When do you think this fix will be released?