Closed Yberion closed 1 year ago
There is a build error.
Hello @santoshyadavdev, the build error seemed to be a problem on netlify's side.
The new pipeline looks fine.
Thank you @Yberion I have updated the node version it was old, I will run the pipeline again to check.
Hello @santoshyadavdev,
This PR fixes https://github.com/uiuniversal/ngu-carousel/issues/476.
What I did:
yarn
at all this time, I switched tonpm
(even after everything was updated withnpm
and switching back toyarn
)jasmine-core
).nx
in.gitignore
ngu-carousel-example
to use the new control-flowREADME.md
ngu-carousel-example
as it was more or less uselessupdateBuildableProjectDepsInPackageJson
fromngu-carousel
as it was deprecatedtsconfig.json
(cypress) in the.eslintrc.json
ofngu-carousel
application
builder, but it was not working properly with modules.I will investigate later if it comes from(thanks @JeanMeche for his help)nx
or theAngular CLI
An interesting point to note is that if either 'ssr' or 'prerender' are set to 'true' in the configuration file, the pages served with 'ng serve' will be generated server side.
ssr-dev-server
& co.browser-esbuild
when I migrated toAngular 16
, so it is already using esbuild.ng serve
using the ssr is not usingserver.ts
(which should not affect this repo, but let's play it safe), track https://github.com/angular/angular-cli/issues/26323polyfills
usageCI
setup18.13.0
, the CI now runs on['18.13.0', '20']
actions/checkout@v4
&actions/setup-node@v4
npm
ngu-carousel
forAngular 17
ngu-carousel
to9.0.0
and I updatedREADME.md
TODO on your side:
9.0.0
Tell me if everything looks ok for you.
Have a nice day.